Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to address #410 I'd like the ability to specify entrypoint parameters. This adds a new setting, dockerEntrypoint, which takes in a Seq[String] and passes that to the ExecCmd form
"ENTRYPOINT"
. It keeps the defaultbin/executableScriptName
in place.On a sidenote, I don't understand the current usage of executableScriptName. This does change the entrypoint value, but it forces the script to be places in
/opt/docker/bin
. It also doesn't change the outputted bin script's name. So it seems you need a specific script in a specific place in your container. I believe passing an ENTRYPOINT exec value is a more flexible approach.Tests/documentation coming, but I wanted to get early feedback.
Thank you,
Mike