#415 custom mainclass for Windows

[tartakynov]

This PR adds an option to set a custom main class on Windows

[lightbend-cla-validator]

Hi @tartakynov,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

[muuki88]

Nice! Looking good. I'll try this on my windows vm.
/cc @nazoking @bjuric - always appreciate a second look :)

[muuki88]

@tartakynov ping here when you signed the CLA :)

[tartakynov]

@muuki88 I've signed the CLA

[nazoking]

thanks. bat this pull-request occurd error on test "windows//test-bat-template".

[info] ---------------------------------
[info] Failed to correctly run the main script!.
[info] "cmd" "/c" "C:\Users\nazoking\AppData\Local\Temp\sbt_7ebab7a7\test-bat-template\target\universal\stage\bin\windows-test.bat" "-Dtest.hoge=C:\Program Files\Java" "C:\Program Files\Java"
[info]
[info] --expected----------------------------
[info] arg #0 is [C:\Program Files\Java]
[info] property(test.hoge) is [C:\Program Files\Java]
[info] SUCCESS!
[info]
[info] --found-------------------------------
[info] error < =C:\Program was unexpected at this time.
[info] error code: 255
[info] --detail-------------------------------
  :
(snip)
  :
[info] > if "!_TEST_PARAM:~0,2!" == "-J" (
[info] rem strip -J prefix
[info]  set _JAVA_PARAMS=!_JAVA_PARAMS! !_TEST_PARAM:~2!
[info]  shift
[info]  goto param_loop
[info] )
[info] error < =C:\Program was unexpected at this time.
[info] >   if ""-Dtest.hoge=C:\Program Files\Java""=="-main" (

it mean error occurd on batch code https://github.com/tartakynov/sbt-native-packager/blob/custom-main-windows/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template#L117

if "%1"=="-main" (

"%1" was expanded on pre-process time before parse time.and if %1 has double-quote, cmd.exe throw parse-error. ( i think, this cmd process is bad design... )

maybe it

  if "!_TEST_PARAM!"=="-main" (
    call set CUSTOM_MAIN_CLASS=%2

"_TEST_PARAM" has %1.

please check 'delayed expansion' keyword in windows batch ( delayed expansion is expend environment value after parse time ).
and run test on your windows machie "scripted windows/*"

[tartakynov]

Ok, I've ran "scripted/test-custom-main" on my Windows 8.1 machine and it went well. Will commit the fix asap

[nazoking]

Thanks your fix. I've ran "scripted windows/*" on my windows-7 machine and all test success.

LGTM.

i think that window batch template need feature #184 `--' to stop parsing options, but it will be another pull request .

[bjuric]

Can confirm that the tests pass on my windows 7 also.

[muuki88]

Awesome, thanks a lot for your support!