Fixes #39 - Unable to follow symlinks. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that we were naively going up a directoryon a bash script. However, we should first find out where the bash script *really* is located, then go up a directory and take the real directory of that to find the installation. This is friendlier to our debian/rpm start scripts. Thanks to @muuki88 for diagnosing and proposing an alternative solution.
|
Review by @havocp |
| @@ -284,7 +284,8 @@ EOM | |||
| declare -a residual_args | |||
| declare -a java_args | |||
| declare -a app_commands | |||
| declare -r app_home="$(realpath "$(dirname "$0")")" | |||
| declare -r real_script_path="$(realpath "$0")" | |||
There was a problem hiding this comment.
As best I can tell from experimenting, you have the quoting correct here, but it's pretty confusing!
havocp
added a commit
that referenced
this pull request
Sep 27, 2013
Fixes #39 - Unable to follow symlinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that we were naively going up a directoryon a bash script.
However, we should first find out where the bash script really is located,
then go up a directory and take the real directory of that to find the installation.
This is friendlier to our debian/rpm start scripts. Thanks to @muuki88 for diagnosing
and proposing an alternative solution.