Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using --startas instead of --exec now in order to make start script idempotent. #457

Merged
merged 1 commit into from
Jan 8, 2015

Conversation

OlegIlyenko
Copy link
Contributor

This will only use PID file to check whether application is started or not. --exec in contrast is also checks the /proc/[PID]/exe file which links to the java executable and not original start script (see this article).

For more detail please see the discussion on #451

I tried to use another solution (exec -a "appName"), but unfortunately it does not work as I expected. So as far as i can tell --startas is the only option.

…pt idempotent. This will only use PID file to check whether application is started or not. `--exec` in contrast is also checks the `/proc/[PID]/exe` file which links to the java executable and not original start script (see [this article](https://chris-lamb.co.uk/posts/start-stop-daemon-exec-vs-startas)). For more detail please see the discussion on sbt#451
muuki88 added a commit that referenced this pull request Jan 8, 2015
Using `--startas` instead of `--exec` now in order to make start script idempotent.
@muuki88 muuki88 merged commit 7f86b4f into sbt:master Jan 8, 2015
@muuki88
Copy link
Contributor

muuki88 commented Jan 8, 2015

Awesome, thanks :)

@muuki88 muuki88 added the 0.8.x label Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants