Fix #531: Simplify stop() function on Debian based systems. #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid complex logic with unhandled corner cases. If a process has crashed leaving an invalid PID file behind, the current logic does not remove the invalid PID file, although the process is not running.
|
Hi @onibox, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
LGTM. On which debian-based system did you test this? |
|
Ubuntu 12.04 LTS |
|
Nice. Tested this this on Ubuntu 14.04 LTS as well. Works smoothly. Thanks for simplifying bash :) |
muuki88
added a commit
that referenced
this pull request
Mar 29, 2015
Fix #531: Simplify stop() function on Debian based systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid complex logic with unhandled corner cases. If a process has
crashed leaving an invalid PID file behind, the current logic does
not remove the invalid PID file, although the process is not running.