Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!Update default dockerBaseImage to official repo #533

Merged
merged 1 commit into from
Mar 29, 2015
Merged

!Update default dockerBaseImage to official repo #533

merged 1 commit into from
Mar 29, 2015

Conversation

danielwegener
Copy link
Contributor

according to https://blog.docker.com/2015/03/updates-available-to-popular-repos-update-your-images/, all dockerfile/* repos will be replaced with an official repository. This may be a better default configuration.

according to https://blog.docker.com/2015/03/updates-available-to-popular-repos-update-your-images/, all dockerfile/* repos will be replaced with an official repository. This may be a better default configuration.
@muuki88
Copy link
Contributor

muuki88 commented Mar 27, 2015

Awesome, thanks. Where you able to run the tests? sbt "scripted docker/*"

@muuki88
Copy link
Contributor

muuki88 commented Mar 27, 2015

Note: Reading the comments on the docker repo, it seems like only open-jdk is supported. However updating is reasonable IMHO

@danielwegener
Copy link
Contributor Author

This was just a ping as I stumbled across the blog post. The PR comes from the github ui and I have not yet tried to sbt-native-packager at all :)
But I can try it later in the evening.

@muuki88 muuki88 added the docker label Mar 28, 2015
@muuki88
Copy link
Contributor

muuki88 commented Mar 29, 2015

Ah, github is amazing :)

I tested this on my machine with docker 1.5 and everything works fine

@muuki88
Copy link
Contributor

muuki88 commented Mar 29, 2015

Thanks :)

muuki88 added a commit that referenced this pull request Mar 29, 2015
!Update default dockerBaseImage to official repo
@muuki88 muuki88 merged commit f60e1a4 into sbt:master Mar 29, 2015
@danielwegener
Copy link
Contributor Author

Awesome :)

@danielwegener danielwegener deleted the patch-1 branch March 29, 2015 11:54
@dhpiggott
Copy link

Does the base image need to include a JDK? I've been using just the JRE image without any problems, but I note that the 'latest' tag of the new official Docker repo (https://registry.hub.docker.com/_/java/) is an alias for openjdk-7-jdk (https://github.com/docker-library/java/blob/4c5beb8bdb21c746bef683f18bdeddee157f61fd/openjdk-7-jdk/Dockerfile), whereas the 'latest' tag of the old Dockerfile repo (https://registry.hub.docker.com/u/dockerfile/java/) was an alias for openjdk-7-jre.

Might it be worth changing it to the 'jre' version, which is an alias for https://github.com/docker-library/java/blob/4c5beb8bdb21c746bef683f18bdeddee157f61fd/openjdk-7-jre/Dockerfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants