Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian scripts are now picked up from default folder #35 #57

Merged
merged 4 commits into from
Oct 31, 2013
Merged

Debian scripts are now picked up from default folder #35 #57

merged 4 commits into from
Oct 31, 2013

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Oct 30, 2013

Debian scripts are now pickup up from src/debian/DEBIAN.
You can override this with debianControlScriptsDirectory setting.

@muuki88
Copy link
Contributor Author

muuki88 commented Oct 30, 2013

This should fix #35
Can you create a milestone and insert all tickets which needs to be fixed to get a release out? Really waiting for this :)

@@ -10,6 +10,7 @@ import linux.LinuxSymlink
import linux.LinuxFileMetaData
import com.typesafe.sbt.packager.Hashing
import com.typesafe.sbt.packager.linux.LinuxSymlink
import java.io.{ File => JFile }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do this. sbt.File == java.io.File.

It's done like so:

package object sbt {
  type File = java.io.File
}

@jsuereth
Copy link
Member

This patch looks amazing caveat 2 minor items. If you fix em up, I'll merge ASAP. Thanks again for the help.

@muuki88
Copy link
Contributor Author

muuki88 commented Oct 31, 2013

Everything fixed. Replacing now works, too with the bashFriendly notation ${{variable}}.
Hopefully we are getting closer to a next release :)

@jsuereth
Copy link
Member

This looks great! Thanks again for the hard work :) Can't wait to use it myself.

jsuereth added a commit that referenced this pull request Oct 31, 2013
Debian scripts are now picked up from default folder #35
@jsuereth jsuereth merged commit dc93fa4 into sbt:master Oct 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants