Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AshScriptPlugin - pass arguments loaded from script conf file #704

Merged
merged 1 commit into from
Nov 29, 2015
Merged

AshScriptPlugin - pass arguments loaded from script conf file #704

merged 1 commit into from
Nov 29, 2015

Conversation

pawelkaczor
Copy link
Contributor

Fixes #702

@muuki88 muuki88 added the docker label Nov 29, 2015
muuki88 added a commit that referenced this pull request Nov 29, 2015
@muuki88
Merge pull request #704 from pawelkaczor/ash-plugin-javaOptions
d2509a7 
AshScriptPlugin - pass arguments loaded from script conf file
@muuki88 muuki88 merged commit d2509a7 into sbt:master Nov 29, 2015
@muuki88
Copy link
Contributor

muuki88 commented Nov 29, 2015

Thanks :)

@dhoepelman
Copy link

@pawelkaczor
What's the reason$@ and $app_mainclass switched positions? Seems like quite a breaking change, at least it was for our app.

Wouldn't something like

[ -f "$script_conf_file" ] && set -- $(loadConfigFile "$script_conf_file") "$opts"
java -classpath $app_classpath "$opts" $app_mainclass $@

be more appropriate?

@muuki88
Copy link
Contributor

muuki88 commented Apr 6, 2016

You are right. Can you provide a PR fixing this?

@dhoepelman dhoepelman mentioned this pull request Apr 6, 2016
Merged
@dhoepelman
Copy link

Sure, #766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelkaczor @muuki88 @dhoepelman