-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new namespace and solve duplicate key issue #802
Conversation
…4 by default but can be changed by user.
The AppVeyor build failure is due to the standard major version being |
@@ -57,6 +57,8 @@ object WindowsPlugin extends AutoPlugin { | |||
"-cultures:en-us"), | |||
wixProductId := WixHelper.makeGUID, | |||
wixProductUpgradeId := WixHelper.makeGUID, | |||
wixMajorVersion := 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to 3
, so we remain backwards compatible and the tests run.
Code looks good. Please add some documentation. You can build the docs with this guide Also an additional windows test would be nice, it seems appveyor only supports Wix 3.10. |
…to the user and conflicts with the user defined AddShortCuts WindowsFeature.
Now also resolves issue #781. Edit: Ugghhh different setup on AppVeyor as it seems. |
So the final solution for #781 was different than I expected: The RemoveFolder directive has nothing to do with shortcuts. I re-inserted the previous standard shortcuts for the config files but removed the RemoveFolder directive for ApplicationFolder from the AddShortcuts xml. It was moved to ApplicationFolder itself so that it appears only once in the very right spot, independent of shortcuts. |
LGTM. I will try t o test it this week on my windows machine. @nazoking do you have time to test this as well? |
…4 by default but can be overridden by user.
Fixes issue #780 and allows using the newest Wix toolset.