Sysvinit script for debian package

[kardapoltsev]

No description provided.

[lightbend-cla-validator]

@kardapoltsev Please sign the latest Typesafe Contributors License Agreement so that we can review and hopefully merge this Pull Request:
http://typesafe.com/contribute/cla

[kardapoltsev]

I did sign the CLA.

[jsuereth]

@kardapoltsev I think it's a new variant of the license or something (says which country/state law it's under which is important for some reason). If not, I apologize, we're experimenting with github pull request hooks and automation.

THanks so much for the patch! I'll dig in and review now. Looking forward to seeing more great work.

[jsuereth]

We can't actually upgrade yet, as we still support 0.12 for at least another 6 months.

[jsuereth]

Code looks great, but raises some architectural questions....

I think I want to drive System V vs. upstart via flag, like:

serverLoading in Debian := ServerLoader.UpStart

serverLoading in Rpm := ServerLoader.SystemV

This does make the change a bit hairer though, as driving settings off values of other settings can make the code a bit convoluted....

What do you think?

[kardapoltsev]

Sure! I could reimplement this part.
Thanks for your review!

Regards, Alexey
On Nov 22, 2013 6:41 PM, "Josh Suereth" notifications@github.com wrote:

Code looks great, but raises some architectural questions....

I think I want to drive System V vs. upstart via flag, like:

serverLoading in Debian := ServerLoader.UpStart
serverLoading in Rpm := ServerLoader.SystemV

This does make the change a bit hairer though, as driving settings off
values of other settings can make the code a bit convoluted....

What do you think?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/85#issuecomment-29069573
.

[kardapoltsev]

Should I create a new pull request with this changes? I'm new in contributing to public repos.

[jsuereth]

Up to you.

What we generally recommend is if you're going to rewrite history on a branch is to name it something with "Work in Progress" or WIP in the name. Otherwise, a new branch can be easier.

In this case, it's up to you what you wish to do.

[kardapoltsev]

I'm done with settings for start system, could you review this version?

[jsuereth]

This looks great! Thanks much for the changes. The only thing I'd like to see now is making this also work for Init.d RPM scripts :) I think that's a follow up PR.

Thanks much for the work. It looks great.

[kardapoltsev]

Thanks!