Introduction: clarify and fix grammar #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of saying "first..." "second..."
…lugin' as it was)
…ntence, then explain what it doesn't do.
…ypes is a separate paragraph and the list of what it provides clearly applies only to the preceding sentence.
…o say this is the diagram for this application.
|
Hi @weedySeaDragon, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
Thanks a lot for taking your time to make the docs a better place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started to learn and use sbt-native-packager. The documentation has been a great help.
I've gone through the Introduction and corrected some grammar mistakes and also strengthened and clarified some places.
This is PR covers just the Introduction page because I didn't want to do too much work before checking to see what was actually wanted and needed. I also didn't squash my commits in case you wanted to review my reasons for each change. (But I can certainly squash them if that's what's wanted.)
If this is helpful, I can do some more sections.