Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in the ash-template #897

Merged
merged 1 commit into from
Oct 30, 2016
Merged

fix a bug in the ash-template #897

merged 1 commit into from
Oct 30, 2016

Conversation

stew
Copy link
Contributor

@stew stew commented Oct 17, 2016

[ "foo" == "bar" ] is not valid posix. It should be a single =, or else you'll get "unexpected operator/operand" on a posix compliant shell:

> posh
$ [ "foo" = "foo" ] && echo yes 
yes
$ [ "foo" == "foo" ] && echo yes
posh: [: ==: unexpected operator/operand

> dash                                                                                                               ⏎
$ [ "foo" = "foo" ] && echo yes 
yes
$ [ "foo" == "foo" ] && echo yes
dash: 2: [: foo: unexpected operator

@lightbend-cla-validator

Hi @stew,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM. I'll keep this open until two weeks and then release it immediately (also for the 1.x series)

@muuki88 muuki88 added the docker label Oct 30, 2016
@muuki88 muuki88 merged commit d9bd270 into sbt:master Oct 30, 2016
muuki88 pushed a commit that referenced this pull request Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants