Adding support for rpm scriptlets #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the %pretrans, %pre, %post, %verifyscript %posttrans, %preun and %postun scriptlets are supported. This currently does not escape percent signs in the contents of the scriptlets
| @@ -25,6 +25,13 @@ trait RpmPlugin extends Plugin with LinuxPlugin { | |||
| rpmPrerequisites := Seq.empty, | |||
| rpmObsoletes := Seq.empty, | |||
| rpmConflicts := Seq.empty, | |||
| rpmPretrans := None, | |||
There was a problem hiding this comment.
Would you mind if I modify this to look for a src/rpm/RPM/pretrans file and slurp in the contents?
I'm a fan of having these guys not inside the build (or SPEC) but external.....
|
This looks great to me, thanks for the patch! I may take what you've done and see if it makes sense to expand for Debian scripts as well, but probably not for a bit. |
jsuereth
added a commit
that referenced
this pull request
Dec 16, 2012
Adding support for rpm scriptlets
|
Thanks for merging my patch in. |
|
Exactly. It's just a matter of adding a check for the file by default and |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the %pretrans, %pre, %post, %verifyscript %posttrans, %preun and %postun scriptlets are supported.
This currently does not escape percent signs in the contents of the scriptlets