Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DebianDeployPlugin not publishing deb file #961

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Fix DebianDeployPlugin not publishing deb file #961

merged 1 commit into from
Apr 12, 2017

Conversation

eed3si9n
Copy link
Member

Fixes #587

By calling SettingsHelper.makeDeploymentSettings twice DebianDeployPlugin only adds "changes" file, but not the "deb" file to the list of artifacts.

@eed3si9n
Fix DebianDeployPlugin not publishing deb file
34cd7f2 
Fixes #587

By calling `SettingsHelper.makeDeploymentSettings` twice DebianDeployPlugin only adds "changes" file, but not the "deb" file to the list of artifacts.
@eed3si9n eed3si9n requested a review from muuki88 April 12, 2017 11:25
muuki88
muuki88 approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :)
I'll try to push a release today

@muuki88 muuki88 added the debian label Apr 12, 2017
@muuki88 muuki88 merged commit c057372 into master Apr 12, 2017
@muuki88 muuki88 deleted the wip/587 branch April 12, 2017 19:32
@eed3si9n eed3si9n mentioned this pull request May 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
debian
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eed3si9n @muuki88