Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for including all dependencies in JAR's to force manifest #97

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add test for including all dependencies in JAR's to force manifest #97

merged 1 commit into from
Nov 2, 2023

Conversation

mdedetrich
Copy link
Collaborator

@mdedetrich mdedetrich commented Oct 28, 2023 •
edited
Loading

@lefou @mdedetrich
Add test for including all dependencies in JAR's to force manifest
3ae7c91 
Co-Authored-By: Tobias Roeser <le.petit.fou@web.de>
@mdedetrich mdedetrich mentioned this pull request Oct 28, 2023
Closed
@mdedetrich
Copy link
Collaborator Author

@eed3si9n You mind reviewing this, @lefou said it all looks good.

@lefou
Copy link
Contributor

lefou commented Nov 1, 2023

In essence, this test makes sure, we calculate proper version ranges for Import-Package based on the OSGi headers of the dependencies. This is an essential feature, and the test should fail for versions up to 0.9.4.

eed3si9n
eed3si9n approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdedetrich mdedetrich merged commit 14aca8c into sbt:main Nov 2, 2023
2 checks passed
@mdedetrich mdedetrich deleted the add-use-all-dependencies-as-JARs-test branch November 2, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

@eed3si9n eed3si9n eed3si9n approved these changes

@romainreuillon romainreuillon Awaiting requested review from romainreuillon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdedetrich @lefou @eed3si9n