Make the generated subproject self-aware about its own virtual axes #36
Conversation
|
So you want to make the subproject self-aware about their virtual axes? I think that's a great idea. |
.gitignore
Outdated
| .bloop | ||
| .metals | ||
|
|
||
| target | ||
|
|
||
| project/.bloop | ||
| project/target | ||
| project/project/target | ||
|
|
||
| *.class | ||
|
|
||
| metals.sbt | ||
|
|
||
| src/sbt-test/projectMatrix/projectAxes/target | ||
| src/sbt-test/projectMatrix/projectAxes/project/target | ||
|
|
||
|
|
There was a problem hiding this comment.
My general preference is to ignore these using global gitignore - https://docs.github.com/en/free-pro-team@latest/github/using-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer
There was a problem hiding this comment.
I will remove it from the PR, can always keep a local copy for myself :)
| @@ -0,0 +1 @@ | |||
| sbt.version=1.4.0-M1 | |||
There was a problem hiding this comment.
Don't think so, I copypasted the one of the jvm ones I think :)
It's also present in two other projects:
./src/sbt-test/projectMatrix/jvm-sandwich-sbt-1.3/project/build.properties
./src/sbt-test/projectMatrix/jvm-sandwich/project/build.properties
I can remove those if you want?
There was a problem hiding this comment.
Apparently those are the only ones that were actually needed :D Kept them.
| @@ -5,10 +5,16 @@ import internal._ | |||
| import java.util.concurrent.atomic.AtomicBoolean | |||
| import scala.language.experimental.macros | |||
|
|
|||
| trait ProjectMatrixKeys { | |||
| val projectAxes = settingKey[Seq[VirtualAxis]]("Virtual axes for the project") | |||
There was a problem hiding this comment.
Calling this projectAxes I think is confusing because we already have subproject axis. What do you think about calling it virtualAxes?
eed3si9n
changed the title
keynmol
force-pushed
the
expose-project-axes
branch
from
88b094b to
c58f78c
Compare
|
Seems like the test on native has been failing before these changes: https://github.com/sbt/sbt-projectmatrix/runs/1371093404 I'm gonna try to track it down with the lovely folks from SN: https://gitter.im/scala-native/scala-native?at=5fb676fbc10273610a15bdba UPDATE: doesn't seem to be related to projectmatrix, I've reproduced it in scala-native/scala-native#2024 on a regular build |
I thought that it would be useful for, say, defining project-wide settings that vary depending on the platform.
Having access to all of the axes can help separate the settings from the raw project matrix definition.
If this doesn't fit with projectmatrix vision, I'm happy not to pursue and just add the recommended approach (once I know it) to the documentation :)
TODO: