Use unmanagedSourceDirectories for sourceDirectories #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sourceDirectories in scalariformFormat` is currently initialized with `List(scalaSource.value)` which means that sbt-scalariform only looks into one source directory per project. But a typical Scala.js cross project has at least two source directories: js/ and shared/ or jvm/ and shared/. In other projects there are multiple source directories for different Scala versions. This change initializes `sourceDirectories in scalariformFormat` with `unmanagedSourceDirectories` which contains all source directories with manually created sources. This setting always includes `scalaSource` because sbt defines it as: ```scala unmanagedSourceDirectories := makeCrossSources( scalaSource.value, javaSource.value, scalaBinaryVersion.value, crossPaths.value) ``` Here are for example both settings for typelevel/cats: > coreJVM/scalaSource [info] cats/core/.jvm/src/main/scala > coreJVM/unmanagedSourceDirectories [info] List( cats/core/.jvm/src/main/scala-2.11, cats/core/.jvm/src/main/scala, cats/core/.jvm/src/main/java, cats/core/src/main/scala) And since cats has no sources in cats/core/.jvm/src/main/scala (all sources are in cats/core/src/main/scala), sbt-scalariform won't format anything. This change has been tested successfully with one of my projects and allowed to get rid of this [workaround](https://github.com/fthomas/refined/blob/8e5fad238524dc4bc32401e37d006705f937f280/build.sbt#L337-L340) to pick up all relevant source directories.
|
It seems that #32 (comment) also suggests to use |
|
@fthomas looks like you moved on to Since Scalariform has been updated to 0.2.0 it makes sense to publish a new release for Sbt-Scalariform as well. Did you encounter any problems after submitting this PR, or were things stable wrt to addressing the scala/scala.js issue? |
|
As far as I remember there where no problems. I did a similar change in the old scalafmt sbt plugin and it didn't caused any trouble there: scalameta/scalafmt#229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceDirectories in scalariformFormatis currently initializedwith
List(scalaSource.value)which means that sbt-scalariform onlylooks into one source directory per project. But a typical Scala.js
cross project has at least two source directories: js/ and shared/
or jvm/ and shared/. In other projects there are multiple source
directories for different Scala versions.
This change initializes
sourceDirectories in scalariformFormatwith
unmanagedSourceDirectorieswhich contains all sourcedirectories with manually created sources. This setting always
includes
scalaSourcebecause sbt defines it as:unmanagedSourceDirectories := makeCrossSources( scalaSource.value, javaSource.value, scalaBinaryVersion.value, crossPaths.value)Here are for example both settings for typelevel/cats:
And since cats has no sources in cats/core/.jvm/src/main/scala
(all sources are in cats/core/src/main/scala), sbt-scalariform
won't format anything.
This change has been tested successfully with one of my projects
and allowed to get rid of this workaround
to pick up all relevant source directories.