Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #1347

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Fix build #1347

merged 1 commit into from
Apr 8, 2024

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Apr 8, 2024

@eed3si9n eed3si9n changed the title Bump protobuf-java 3.25.3 Fix build Apr 8, 2024
@eed3si9n eed3si9n merged commit adc050d into sbt:develop Apr 8, 2024
8 checks passed
@eed3si9n eed3si9n deleted the wip/protoc branch April 8, 2024 07:34
@SethTisue
Copy link
Member

@eed3si9n after this change, I can no longer zincPersistCore / Protobuf / protobufRunProtoc, either in the community build (where I noticed the problem) or locally?

[error] java.lang.RuntimeException: protoc was not found: Vector()
[error] 	at scala.sys.package$.error(package.scala:30)
[error] 	at sbtprotobuf.SbtProtobuf$.extractFile(SbtProtobuf.scala:72)
[error] 	at sbtprotobuf.ScopedProtobufPlugin.$anonfun$projectSettings$24(ProtobufPlugin.scala:107)
[error] 	at sbtprotobuf.SbtProtobuf$.withFileCache(SbtProtobuf.scala:60)
[error] 	at sbtprotobuf.ScopedProtobufPlugin.$anonfun$projectSettings$23(ProtobufPlugin.scala:106)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:49)
...

@eed3si9n
Copy link
Member Author

@SethTisue Are you on some branch? On e902ec9 it works fine on my machine:

sbt:zinc Root> show zincPersistCore / Compile / sources
[info] compiling 2 protobuf files to /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf
[info] Compiling schema /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/src/main/protobuf/schema.proto
[info] Compiling schema /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/src/main/protobuf/zprof.proto
[info] Compiling protobuf
[info] Protoc target directory: /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf
[info] * /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf/sbt/internal/inc/Schema.java
[info] * /Users/eed3si9n/work/sbt-modules/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf/sbt/internal/prof/Zprof.java

@SethTisue
Copy link
Member

SethTisue commented Apr 25, 2024

yeah I'm at e902ec9

and hmm, well, it still fails in the community build (both on Jenkins and locally), but it doesn't fail for me locally anymore outside of dbuild. I don't know what to make of it

I'll poke at it some more, I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants