sync #28
Merged
sync #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync master
Refactor Javascript and Stylesheet loading
Generate nugets in correct format
Sync upstream
Added wildcard route catchall.
- safe way to check if key is presented
- safe parsing int values in query
- should replace int.Parse()
_jobId = Int32.Parse(PageState.QueryString["id"]);
can throw unhandled exception when "id" is not int
correct way
if (PageState.Uri.TryGetQueryValueInt("id",out _jobId)) ....
fixed stylesheet and script removal logic
Fix Alias name route
Search in User management
Uri extensions for read query values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.