Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locate .coverage_contracts correctly for subfolder paths #570

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Nov 16, 2020

#559

Fixes a bug where the temporary contracts directory is always placed in the root of the project.

When contracts_directory or paths.sources references a subfolder, e.g contracts/legacy and imports from adjacent folders, none of the Solidity import statements resolve correctly.

In this case, .coverage_contracts should be a subfolder of contracts.

@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #570 (423a9c2) into master (f5ed5e5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          22       22           
  Lines         955      955           
=======================================
  Hits          946      946           
  Misses          9        9           
Impacted Files Coverage Δ
plugins/resources/plugin.utils.js 97.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ed5e5...5c9c550. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants