Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chained ternary conditionals instrumentation #830

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Jan 26, 2024

In #751 instrumentation failed due to solidity-parser/parser 99.

#829 fixed this but while adding tests discovered another bug - the parser was not drilling down into the conditional chain to instrument things at lower levels.

PR fixes that. Tests only verify that the statements compile after instrumentation but coverage logic should be fine - the chain is just more of the same.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc54ef5) 96.47% compared to head (c5cc147) 96.48%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
+ Coverage   96.47%   96.48%   +0.01%     
==========================================
  Files          19       19              
  Lines        1049     1053       +4     
==========================================
+ Hits         1012     1016       +4     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke merged commit a6674c6 into master Jan 26, 2024
3 checks passed
@cgewecke cgewecke deleted the ternary-751 branch January 26, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants