Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instrumentation error for virtual modifiers #832

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

cgewecke
Copy link
Member

#766

Updates parsing to check that modifier definitions have a body before instrumenting them (like functions)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70de9d4) 96.48% compared to head (997ce70) 96.48%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          19       19           
  Lines        1053     1054    +1     
=======================================
+ Hits         1016     1017    +1     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke merged commit 658dc37 into master Jan 26, 2024
3 checks passed
@cgewecke cgewecke deleted the virtual-modifier branch January 26, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants