Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start-up: differentiate between cold and warm starts #17

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

csegarragonz
Copy link
Contributor

@csegarragonz csegarragonz commented Dec 20, 2024

To-Do:

  • Report how we pull an image twice in CoCo
  • Should we also clean-up the sidecar image? (I'm thinking yes)
  • Fix the fetch content problem below

There is a deeper error when we try to measure real cold starts. Which is that, if we clean-up the app image from CRI, we consistently get the fetch content error:

failed to extract layer sha256:1e604deea57dbda554a168861cff1238f93b8c6c69c863c43aed37d9d99c5fed: failed to get reader from content store: content digest sha256:9fa9226be034e47923c0457d916aa68474cdfb23af8d4525e9baeebc4760977a: not found

Will keep this PR as a draft until we can fix this in sc2-sys/deploy, which will involve getting our hands dirty with the snapshotters.

Turns out most of the issues above came from not setting the right pod annotation (io.containerd.cri.runtime-handler: kata-qemu-...).

@csegarragonz csegarragonz marked this pull request as ready for review January 15, 2025 17:33
@csegarragonz csegarragonz merged commit 146b22d into main Jan 15, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant