start-up: differentiate between cold and warm starts #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-Do:
There is a deeper error when we try to measure real cold starts. Which is that, if we clean-up the app image from CRI, we consistently get the fetch content error:
Will keep this PR as a draft until we can fix this in
sc2-sys/deploy
, which will involve getting our hands dirty with the snapshotters.Turns out most of the issues above came from not setting the right pod annotation (
io.containerd.cri.runtime-handler: kata-qemu-...
).