remove parseEther from useScaffoldContractWrite
#548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rin-st
reviewed
Sep 29, 2023
rin-st
approved these changes
Sep 29, 2023
carletex
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Yep, glad we are merging this in! Thanks @technophile-04 !!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #516, I agree with the discussion and also makes sense now 🙌
also btw the type of
valuethat we had was a bit too harsh as it was typed as${number}lol which was a PITA to get it right until you write your own validate function helper or assert it withasor just pass in literal value like "0.1".Here is an example that might frustrate users:
Nevertheless, this PR removes
parseEtherfromuseScaffoldContractWriteso we leave it to users, which solves all the issue 🙌