Improve ENS support (accept all TLDs) #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gskril for bringing up this issue and tackling it, really appreciate it !! Added a small comment but overall looks clean, great, and works nicely too! |
rin-st
reviewed
Oct 10, 2023
|
Tysm @gskril !! and Thanks all for the reviews, merging this 🙌 |
carletex
added a commit
that referenced
this pull request
Oct 12, 2023
* Tweak DaisyUI `link` (#560) * Improve ENS support (accept all TLDs) (#563) * fix: memo history events (#565) * update developer guide with backmerge-main instructions * add changeset --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Filip Harald <Filip.harald@gmail.com> Co-authored-by: Greg <35093316+gskril@users.noreply.github.com> Co-authored-by: Rinat <rinat@hey.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Merged
carletex
added a commit
that referenced
this pull request
Oct 23, 2023
* Tweak DaisyUI `link` (#560) * Improve ENS support (accept all TLDs) (#563) * fix: memo history events (#565) Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Extract header menu links (#570) * Move Block Explorer to footer (#574) * Remove ExampleUI (pages, components, assets, content) (#578) * update wagmi, viem, rainbowkit (#580) * add zkSync, scroll & polygonZkEvm to foundry.toml * add changeset --------- Co-authored-by: Filip Harald <Filip.harald@gmail.com> Co-authored-by: Greg <35093316+gskril@users.noreply.github.com> Co-authored-by: Rinat <rinat@hey.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Treat any dot-separated string as a potential ENS name rather than hardcode a few TLDs, as suggested by the ENS docs
Additional Information
Related Issues
Closes #562
Your ENS/address: gregskril.eth