-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy to clipboard to TxReceipt #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !! LGTM !
Thanks @damianmarti 🙌
Nice! Thanks @damianmarti The only thing that I'd explore is to position the copy icon in a different place (rn It feels a bit in the middle of nowhere) The standard seems to be on the top right, but since we already have the arrow, might look a bit weird: Another option could be next to the title: We'd have to tweak a bit since that whole "row" collapses the result on click. Anyway, just a suggestion, not a big deal if we keep it as it is! |
@carletex yeah, I know, it's not the best place. Next to the title is the best option, but we should remove the row collapse by clicking the header and moving it to only the arrow. I will try it! |
@carletex what do you think now? The receipt is copied by clicking the copy icon and the receipt is expanded if you click anywhere else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @damianmarti !!! I think this looks better. |
Description
Add copy to clipboard to transaction receipt to allow to copy the transaction data easily.
Additional Information
Your ENS/address: damianmarti.eth