Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos #668

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Typos #668

merged 2 commits into from
Dec 19, 2023

Conversation

carletex
Copy link
Member

Noticed a couple of typos that were repeating on #665 (after merging 😓): corrsponding and scaffold.congfig.ts, so decided to create this PR with other typos that have been bugging me for a while.

Also added some new lines on long comments (trying to stay close to the 120 line length). This is just a convention, and some people have soft-wraps enabled anyway... but I think it's a good convention.

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm !!! Looks great to me !

Also added some new lines on long comments (trying to stay close to the 120 line length). This is just a convention, and some people have soft-wraps enabled anyway... but I think it's a good convention.

Yup 💯! Lol while writing those comments I was enabling soft wrap manually should have wrapped them directly in actual file instead.

It would have been great if prettier had handled this properly since we have printWidth set but it has problem with wrapping comments prettier/prettier#265 :(

I am also keeping close eye on Biome for future 😂 , maybe this from biome can solve it

@technophile-04 technophile-04 merged commit 7584b11 into main Dec 19, 2023
1 check passed
@technophile-04 technophile-04 deleted the typos branch December 19, 2023 20:02
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants