Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nprogress + use next-nprogress-bar #943

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

carletex
Copy link
Member

When we migrated to the App Router #535 we switched from https://www.npmjs.com/package/next-nprogress-bar to https://www.npmjs.com/package/nprogress + creating a custom integration with the App Router.

We already had an issue with external _blank links #909 and now I realized that we have the same problem with hash links (#section). The progress bar will start to load (it shouldn't do anything)

One solution will be to just parse the #links and fix it, but created this PR with another alternative: moving back to next-nprogress-bar which has been updated and supports the App Router nicely. Under the hood it does the same thing that we are doing, but it's handling some stuff a bit better. So it'll be moving custom logic to an external library.

Happy to close this, just wanted to hear your take on it.

Thanks!!

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree let's return to next-progress-bar since it's up to date. Working great for me!

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Also seems to nicely work with a tags(not showing the loader)

@technophile-04 technophile-04 merged commit be59634 into main Sep 19, 2024
1 check passed
@technophile-04 technophile-04 deleted the progress-bar branch September 19, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants