Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

#83/improvements #84

Merged
merged 30 commits into from
Apr 25, 2022
Merged

#83/improvements #84

merged 30 commits into from
Apr 25, 2022

Conversation

ShravanSunder
Copy link
Contributor

@ShravanSunder ShravanSunder commented Apr 19, 2022 •
edited
Loading

ShravanSunder and others added 14 commits March 18, 2022 22:01
@ShravanSunder
updated networks
b09f953
@ShravanSunder
update packages to fix bugs see eth-hooks#177
ed0d42b
@grothem @ShravanSunder
Add verify script (#79)
ea76b24 
* Updated comments to match file and script names

* Added verify script

Co-authored-by: Shravan Sunder <ShravanSunder@users.noreply.github.com>
@ShravanSunder
#83 created a common workspace lib for shared models
45de4fa
@ShravanSunder
#83 created a common workspace lib for shared models
3549538
@ShravanSunder
#83 created a common workspace lib for shared models
7ef8e77
@ShravanSunder
#83 created a common workspace lib for shared models
01d44fc
@ShravanSunder
#83 integrate changes from the LF grow hackathon
86c5bf3
@ShravanSunder
#83 created helper to make pages, routes and tabs and consolidate this
e59d7ed
@ShravanSunder
#83 fixed some bugs
317aa7c
@ShravanSunder
#83 cleaned up tests and hardhat tasks
24f25d9
@ShravanSunder
#83 fixed hardhat project and also updated tasks and hardhat extensions
6e72c26
@ShravanSunder
#83 updated hardhat types
745d315
@ShravanSunder
#83 updated hardhat types
d0d68fd
@ShravanSunder ShravanSunder marked this pull request as ready for review April 19, 2022 13:18
@ShravanSunder ShravanSunder requested a review from grothem April 19, 2022 13:18
@ShravanSunder ShravanSunder marked this pull request as draft April 19, 2022 13:59
dvinubius and others added 2 commits April 19, 2022 09:59
@dvinubius @ShravanSunder
Fix for correct page load on nested routes (#81)
83eba0c 
Resources are not loaded correctly on nested routes.

Co-authored-by: Shravan Sunder <ShravanSunder@users.noreply.github.com>
@ShravanSunder
#83 updating tests
1651e55
grothem
grothem reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@grothem grothem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks like some good improvements. I like scaffold-common project for sharing stuff between the front end and hardhat.

I did noticed you removed ExampleUI.tsx, any particular reason? Could be helpful for new people just getting started.

I pulled your branch and fired everything up, I didn't have any issues!

packages/vite-app-ts/src/MainPage.tsx Show resolved Hide resolved
packages/vite-app-ts/src/components/main/createPagesAndTabs.tsx Show resolved Hide resolved
@ShravanSunder
Copy link
Contributor Author

ShravanSunder commented Apr 25, 2022 •
edited
Loading

Overall looks like some good improvements. I like scaffold-common project for sharing stuff between the front end and hardhat.

I did noticed you removed ExampleUI.tsx, any particular reason? Could be helpful for new people just getting started.

I pulled your branch and fired everything up, I didn't have any issues!

@grothem
i mostly removed it as it was a lot of overhead keeping it working and not much value. People can just use the eth-components library now and look at the docs for understanding UX components

@ShravanSunder ShravanSunder marked this pull request as ready for review April 25, 2022 17:58
ShravanSunder and others added 2 commits April 25, 2022 14:06
@ShravanSunder
#83 some flow changes
30cd547
@kamikazebr @ShravanSunder
Fix/subgraph (#85)
5932a10 
* fix: subgraph, mustache and commands

* doc: improvment in readme

Co-authored-by: Shravan Sunder <ShravanSunder@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Apr 25, 2022 •
edited
Loading

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit cbb2c1e.

♻️ This comment has been updated with latest results.

@ShravanSunder ShravanSunder merged commit dad1a79 into release Apr 25, 2022
@ShravanSunder ShravanSunder deleted the #83/improvements branch April 25, 2022 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grothem grothem grothem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShravanSunder @grothem @dvinubius @kamikazebr