feat: backmerge 21/03/2024 #158
Conversation
There was a problem hiding this comment.
TYSM @rin-st for start working in the backmerge to the challenges!
I've been trying to reproduce the vercel deployment problem in the base-challenge-template but it's working both from CLI with yarn vercel and connecting the Github repo to Vercel. Backmerge branch is working good also in both cases.
Did you manage to reproduce the Vercel problems in the base-challenge-template branch? Maybe I'm doing something wrong 😥
I didn't even test
|
There was a problem hiding this comment.
if Shiv said that we need backmerge I believe he is right 💯 😄
💯 I would even send him my private keys if he asked so :)
🤣🤣🤣 🫶 lol, really sorry I didn't provide full context
Actually when you deploy your app to vercel through CLI, vercel now uses npm install as default instead of yarn install to install dependencies.
Although using npm install works in most of the cases (Like in this case bare se-2) sometimes when you have other dependencies it will break on vercel prod even though it works nicely locally (since locally we used yarn as package manger) an good example of this is #153
Hence in #153 and in SE-2#780 we explicitly tell vercel to use yarn install so that we are relaxed and more sure it will deploy properly since it worked locally.
Tysm @rin-st for tackling it ! and @Pabl0cks for testing ! 🙌
* fix: remove redundant logs * feat: challenge test example (#156) * feat: backmerge 21/03/2024 (#158) * just warn for unused-vars * feat: fn try catch wrapper * feat: wrap write fn * fix: update wrapInTryCatch * fix: wrap write functions --------- Co-authored-by: Shiv Bhonde <shivbhonde04@gmail.com>
* fix: remove redundant logs * feat: challenge test example (#156) * feat: backmerge 21/03/2024 (#158) * wrap write calls in try catch * add await while stakeETH function * feat: fn try catch wrapper * feat: wrap write functions * fix: update wrapInTryCatch * fix: wrap write functions --------- Co-authored-by: Shiv Bhonde <shivbhonde04@gmail.com>
* Update README to add a Guide to create New Challenges (#9) * Update base template README with guide and hints to create new challenges * README tweaks and add TODO questions * Remove initial hints (will move it main) --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Install section fromn Challenge 0 * fix: install duplicate (#24) * Homogenize Checkpoint titles and Checkpoint 0 extra info (#32) * Ignore typescript/eslint errors on build (#39) * fix: sepolia and wc2 (#47) * fix: theme toggle styles (#46) * migration to wagmi V1, Viem and daisyUI v3 (#73) * remove vercel:yolo from root pacakge.json (#77) * Update useScaffoldContractWrite.ts - Error message typos * fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * remove use of custom light blue color for copy icon (#104) * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode * Base challenge next 14 migration (#126) * fix: return space-grotesk font (#129) * feat: migrate next-theme (#132) * fix: remove redundant logs * feat: challenge test example (#156) * feat: backmerge 21/03/2024 (#158) * fix: remove ChallengeN test file * feat: fn try catch wrapper * feat: wrap write functions * fix: update wrapInTryCatch * feat: update wrapped functions --------- Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Zak G <zakgriffith@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
* Ignore typescript/eslint errors on build (#39) * fix: sepolia and wc2 (#47) * fix: theme toggle styles (#46) * migration to wagmi V1, Viem and daisyUI v3 (#73) * remove vercel:yolo from root pacakge.json (#77) * Update useScaffoldContractWrite.ts - Error message typos * fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * remove use of custom light blue color for copy icon (#104) * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode * Base challenge next 14 migration (#126) * fix: return space-grotesk font (#129) * feat: migrate next-theme (#132) * fix: remove redundant logs * feat: challenge test example (#156) * feat: backmerge 21/03/2024 (#158) * fix: remove ChallengeN test file * feat: fn try catch wrapper * fix: update wrapInTryCatch * fix: wrap write functions --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Zak G <zakgriffith@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
first step of #157