Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenge 0: fix vercel deployments #91

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

technophile-04
Copy link
Collaborator

Description :

  1. Locked the version of next for now checkout Challenge 0: use different package instead of react-json-view #90 for more description, fixes Challenge 0 - Checkpoint 4 deploy to Vercel build error with defaults  #89

  2. Fix eth price as 0 on sepolia fix 0 ETH price on sepolia network #85

  3. Also fixed navlinks Icon and text breaks when deployed we fixed this in SE-2 at add grid and grid-flow class to li manually scaffold-eth-2#510 (need to update this on other branches too 🙌)

@carletex
Copy link
Member

Thanks for being so fast @technophile-04 <3

I agree, locking the version is the best solution for now.

As you mentioned, let's also do 3 for the other challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Challenge 0 - Checkpoint 4 deploy to Vercel build error with defaults
2 participants