Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using tabs to split between Hardhat- and Foundry-environment #77

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

FilipHarald
Copy link
Contributor

It's a bit ugly to get tabs to work with code-blocks in them. But perhaps it's worth it for the reader? Could also be possible to duplicate the doc entirely and just have two tabs for all of the info.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scaffold-eth-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 8:36am

@FilipHarald
Copy link
Contributor Author

I noticed that I branched from my other PR-branch (#76 ). So I'm keeping this as draft until that one is resolved.

@FilipHarald
Copy link
Contributor Author

@technophile-04
Copy link
Collaborator

Looks clean and nice!!! Just cc @Pabl0cks and @carletex once they can check the demo here.

also @FilipHarald could you please the fix the conflicts? incase we plan to go ahed with it we should also update https://docs.scaffoldeth.io/deploying/deploy-smart-contracts

@FilipHarald FilipHarald marked this pull request as ready for review August 19, 2024 08:32
@FilipHarald
Copy link
Contributor Author

Updated deploying/deploy-smart-contracts ✔️

Copy link
Member

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it!! Good stuff @FilipHarald

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner for the user! TYSM @FilipHarald 🙌

@Pabl0cks Pabl0cks merged commit f9344bb into scaffold-eth:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants