-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using tabs to split between Hardhat- and Foundry-environment #77
Using tabs to split between Hardhat- and Foundry-environment #77
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I noticed that I branched from my other PR-branch (#76 ). So I'm keeping this as draft until that one is resolved. |
Looks clean and nice!!! Just cc @Pabl0cks and @carletex once they can check the demo here. also @FilipHarald could you please the fix the conflicts? incase we plan to go ahed with it we should also update https://docs.scaffoldeth.io/deploying/deploy-smart-contracts |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it!! Good stuff @FilipHarald
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner for the user! TYSM @FilipHarald 🙌
It's a bit ugly to get tabs to work with code-blocks in them. But perhaps it's worth it for the reader? Could also be possible to duplicate the doc entirely and just have two tabs for all of the info.