Omit explicit parameter types of anonymous functions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s earlier. Does not interfere with the task.
…s earlier. Does not interfere with the task.
FRosner
reviewed
May 18, 2018
| x * 10 | ||
| }) | ||
| .apply(6) should be(res0) | ||
| Semigroup[Int => Int].combine({ _ + 1 }, { _ * 10 }).apply(6) should be(res0) |
There was a problem hiding this comment.
Do we need the curly braces here?
There was a problem hiding this comment.
Sure. We dont need it
FRosner
reviewed
May 19, 2018
| x * 10 | ||
| }) | ||
| .apply(6) should be(res0) | ||
| Semigroup[Int => Int].combine(_ + 1 , _ * 10).apply(6) should be(res0) |
There was a problem hiding this comment.
Nice. Would you mind fixing the spaces and then LGTM!
Semigroup[Int => Int].combine(_ + 1, _ * 10).apply(6) should be(res0)
|
Thats it. Didn't notice |
FRosner
approved these changes
May 20, 2018
|
Thanks @Kobenko! Merging if no further discussions. |
FRosner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can omit the naming of types, as we mentioned this earlier. Does not interfere with the task.