Skip to content

Add a Scala tutorial #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 19, 2017
Merged

Conversation

julienrf
Copy link
Collaborator

This tutorial contents is based on the Scala MOOCs (on Coursera) (cf scala-exercises/scala-exercises#603)

Can someone rename this repository to exercises-scalatutorial?

Copy link

@jdesiloniz jdesiloniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrf sorry, didn't see your PR! I've renamed the repo as you requested.

LGTM!

@juanpedromoreno
Copy link
Contributor

Hey @jdesiloniz @julienrf !

Is this PR ready to be merged? Thanks!

@julienrf
Copy link
Collaborator Author

Hi Juan, thanks for asking! I would wait a little bit before merging because we might polish a few things. Our task queue has several other tasks with a higher priority but we will go back to this one soon.

@heathermiller
Copy link

This looks really nice to me! Is it ready to merge yet @julienrf? What else would you like to do?

@julienrf
Copy link
Collaborator Author

julienrf commented Jan 18, 2017

We can merge it, thanks for reviewing!

- Clone this repository, compile and publish the project:

~~~ sh
git clone git@github.com:scalacenter/exercises-fpprinciples.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this would need to change before merge. Same for directory below, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@julienrf
Copy link
Collaborator Author

@jdesiloniz @juanpedromoreno I think only you have the right to merge it :)

@juanpedromoreno
Copy link
Contributor

Thanks!

@juanpedromoreno juanpedromoreno merged commit 997e5a1 into scala-exercises:master Jan 19, 2017
@raulraja
Copy link
Member

@julienrf @heathermiller I made you both admins in this repo in case you want to moderate or modify its content. We are beyond excited for this PR, thanks so much for your time and this PR.

@MaureenElsberry
Copy link
Contributor

Hi, @heathermiller and @julienrf - I sent you both an email regarding our announcement for when this library is released on the platform for a quick review before we publish. Let me know if you want anything changed! And this is awesome, great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants