Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options type error (Issue #13) #14

Merged
merged 2 commits into from
Jun 17, 2016
Merged

Options type error (Issue #13) #14

merged 2 commits into from
Jun 17, 2016

Conversation

idarlington
Copy link
Contributor

@idarlington idarlington commented Jun 17, 2016

Problem

Test in the options exercise throws an error because the test expects a Float instead of a Double from the user

Solution

Change type of argument to Doube

Problem

Test in the options exercise throws an error because the test expects a Float instead of a Double from the user

Solution

Change type of argument to doube
@raulraja
Copy link
Member

@idarlington Contribution looks great but the OptionSpec that checks for successful test run needs to be fixed to use Double too :)

@raulraja raulraja merged commit 97851f2 into scala-exercises:master Jun 17, 2016
@raulraja
Copy link
Member

LGTM! thanks for your contribution!
Fixes #13

@idarlington
Copy link
Contributor Author

Thanks, @raulraja would love to be part of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants