Skip to content

Fix reuse list tail exercise #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2016
Merged

Fix reuse list tail exercise #26

merged 4 commits into from
Jun 27, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 27, 2016

Based on the work by @idarlington

@ghost ghost mentioned this pull request Jun 27, 2016
@ghost
Copy link
Author

ghost commented Jun 27, 2016

@raulraja please take a look.

@raulraja
Copy link
Member

LGTM!

@raulraja raulraja merged commit 694c4a5 into master Jun 27, 2016
@raulraja raulraja deleted the reuse-tail-list-exercise branch June 27, 2016 08:34
@idarlington
Copy link
Contributor

Hi @dialelo thanks, concerning hanging sbt test you have any idea why and any solutions?

@ghost
Copy link
Author

ghost commented Jun 27, 2016

Was your sbt test hanging? Weird. Compilation of tests is a bit slow since it uses Shapeless heavily but I've never experienced hanging tests, maybe tweaking the JVM settings can help?

@raulraja
Copy link
Member

Try running sbt -v test and see what JVM args SBT is running with. It's most likely an OOM.

@idarlington
Copy link
Contributor

@dialelo @raulraja I set max heap size at 2G and it still hangs at this point

[warn] 5 warnings found
[info] Compiling 37 Scala sources to /home/idarlington/Documents/REPOS/exercises-stdlib/target/scala-2.11/test-classes...

@raulraja
Copy link
Member

What is the output of sbt -v test ?

@idarlington
Copy link
Contributor

@raulraja this

[process_args] java_version = '1.8.0_91'
# Executing command line:
java
-Xmx2G
-XX:+UseConcMarkSweepGC
-XX:+CMSClassUnloadingEnabled
-XX:MaxPermSize=2G
-Xss2M
-Duser.timezone=GMT
-jar
/usr/share/sbt-launcher-packaging/bin/sbt-launch.jar

@raulraja
Copy link
Member

That seems fine. Try sbt clean test

@idarlington
Copy link
Contributor

Still hangs.

@raulraja
Copy link
Member

I can't repro that, perhaps with more info about your environment. Builds
fine on travis which are usually crappy machines, so must be something
related to your setup.

On Mon, Jun 27, 2016 at 12:40 PM Ikenna Darlington Ogbajie <
notifications@github.com> wrote:

Still hangs.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAb4XLd4sip4gTDFzHqHzgCFn29Stmjkks5qP6iagaJpZM4I-3QL
.

@idarlington
Copy link
Contributor

idarlington commented Jun 27, 2016

I am runnning it on
Ubuntu 14.04,
12GB RAM,
sbt 0.13.7,
Java 1.8.0_91

@raulraja
Copy link
Member

Can you try updating your sbt to the latest stable. That is an old version.
Not sure it matters since the launcher can fetch latest but in case.

On Mon, Jun 27, 2016 at 7:30 PM Ikenna Darlington Ogbajie <
notifications@github.com> wrote:

I am runnning it on
Ubuntu 14.04,
12GB RAM,
sbt 0.13.7,
java "1.8.0_91"


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAb4XHOBBgxDltK7Ic_2coGEKMd1uGZRks5qQAi8gaJpZM4I-3QL
.

@idarlington
Copy link
Contributor

Hi, @raulraja , @dialelo it works fine now, had to delete the local version and clone it again. Thanks for trying to resolve this with me.

@raulraja
Copy link
Member

Cool!

On Tue, Jun 28, 2016, 12:28 AM Ikenna Darlington Ogbajie <
notifications@github.com> wrote:

Hi, @raulraja https://github.com/raulraja , @dialelo
https://github.com/dialelo it works fine now, had to delete the local
version and clone it again. Thanks for trying to resolve this with me.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAb4XJHXpglBQrmvss3sj1J6jN0J2q6Pks5qQE50gaJpZM4I-3QL
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants