Replace DataLayout/LayoutOf/LayoutI #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 51.63% 56.67% +5.04%
==========================================
Files 49 49
Lines 1257 1244 -13
Branches 19 22 +3
==========================================
+ Hits 649 705 +56
+ Misses 608 539 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
markehammons
force-pushed
the
markehammons/issue39
branch
from
d8691f0 to
0ba02bb
Compare
This commit creates TypeDescriptor, and replaces most LayoutOf with a conversion from DescriptorOf to LayoutOf.
Removed DataLayout as a dependency from Send, Recieve, and Descriptor
markehammons
force-pushed
the
markehammons/issue39
branch
from
0d928ee to
9b194d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataLayout, LayoutI, and LayoutOf are ridiculously complex. Replace them with a more simple implementation that creates a hard distinction between platform and core.