Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URLSearchParams to BodyInit for fetch #634

Closed
armanbilge opened this issue Nov 17, 2021 · 3 comments · Fixed by #722
Closed

Add URLSearchParams to BodyInit for fetch #634

armanbilge opened this issue Nov 17, 2021 · 3 comments · Fixed by #722

Comments

@armanbilge
Copy link
Member

Blob | BufferSource | FormData | String // todo: add URLSearchParams

@armanbilge armanbilge added this to the v2.1.0 milestone Nov 17, 2021
@armanbilge armanbilge removed this from the v2.1.0 milestone Dec 26, 2021
@zetashift
Copy link
Contributor

Shouldn't the scaladoc comment for BodyInit point to https://fetch.spec.whatwg.org/#bodyinit-unions ? At the very least the current link links to the ToC of the spec hehe.

Also is this issue really as easy as just adding URLSearchParams to the union?

@armanbilge
Copy link
Member Author

Thanks, that seems better :)

Also is this issue really as easy as just adding URLSearchParams to the union?

Famous last words 😝 it should be, but I haven't checked if URLSearchParams exists at least 😂

@zetashift
Copy link
Contributor

@armanbilge armanbilge linked a pull request Aug 21, 2022 that will close this issue
armanbilge added a commit that referenced this issue Aug 21, 2022
Add `URLSearchParams` to `BodyInit`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants