Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto new-based constructors? #670

Open
armanbilge opened this issue Jan 13, 2022 · 0 comments
Open

Fix crypto new-based constructors? #670

armanbilge opened this issue Jan 13, 2022 · 0 comments

Comments

@armanbilge
Copy link
Member

Continuation of #624.

I "fixed" that one in #657 but only looked at Init types and neglected the many crypto types which turns out need the same treatment. I noticed this while reviewing #667.

This one is harder, because it seems that many of the members are actually required and not optional, as was generally the case for the Init types. So if we made this change, when used required members would be defined as vals but the optional ones would be set imperatively, which is a bit strange but maybe okay.

Source-breaking, once again, and possibly not worth it in this case. But in general I think the type signatures for crypto stuff need to be improved, so linking to #660.

@armanbilge armanbilge added this to the v2.2.0 milestone Jan 20, 2022
@armanbilge armanbilge removed this from the v2.2.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant