Add WebCryptoApi tests #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexITC
changed the title
armanbilge
reviewed
Jan 13, 2022
tests-shared/src/main/scala/org/scalajs/dom/tests/shared/SharedTests.scala
Outdated
Show resolved
Hide resolved
armanbilge
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Thanks, LGTM! Much appreciated :)
Now let's see if we can come up with a fix in #669...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, this showcased a broken method in the web crypto api facade.
Let's add some tests to prevent this from occurring again, also, these tests should be useful for people willing to use the web crypto api in scalajs.