Skip to content

Storage#length should be a def #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
armanbilge opened this issue Oct 19, 2022 · 0 comments · Fixed by #737
Closed

Storage#length should be a def #729

armanbilge opened this issue Oct 19, 2022 · 0 comments · Fixed by #737
Labels
bug good first issue We'd love a PR! help wanted

Comments

@armanbilge
Copy link
Member

scala-js-dom/dom/src/main/scala/org/scalajs/dom/Storage.scala

Line 19 in dde2aba

var length: Int = js.native

@armanbilge armanbilge linked a pull request Nov 2, 2022 that will close this issue
Change Storage#length to a def instead of var #737
Merged
armanbilge added a commit that referenced this issue Nov 2, 2022
@armanbilge
Merge pull request #737 from zetashift/fix/#729
714813e 
Change `Storage#length` to a `def` instead of `var`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue We'd love a PR! help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Storage#length to a def instead of var zetashift/scala-js-dom
1 participant
@armanbilge