Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in "WriteableStream" trait name? #754

Open
raquo opened this issue Dec 29, 2022 · 1 comment
Open

Typo in "WriteableStream" trait name? #754

raquo opened this issue Dec 29, 2022 · 1 comment
Labels
bug don't PR We won't accept a PR for this right now
Milestone

Comments

@raquo
Copy link
Contributor

raquo commented Dec 29, 2022

It seems that the native interface is actually called WritableStream, however Scala trait name has an extra e character in it.

I'm not familiar with this API, the trait is not JSGlobal, and I don't actually see how one could get instances of this trait in scala-js-dom, but nevertheless it should probably match the native name?

@armanbilge armanbilge added the bug label Dec 29, 2022
@armanbilge
Copy link
Member

Thanks, this indeed seems like a mistake :( there are actually many issues with those facades, see #629.

I don't think we can fix this binary-compatibly. Maybe we can add a type alias with the correct name.

@armanbilge armanbilge added the don't PR We won't accept a PR for this right now label Jan 28, 2023
@armanbilge armanbilge added this to the v3.0.0 milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug don't PR We won't accept a PR for this right now
Projects
None yet
Development

No branches or pull requests

2 participants