Add the Notification API #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @JSExport | ||
| object Notification { | ||
| @JSExport |
There was a problem hiding this comment.
The Example.scala is for examples in the Readme. And we want to keep the readme short with only an introduction to scala-js-dom as a whole (not with an example of every possible sub-part of the API). So you should not change Example.scala. Especially since this example can found on MDN.
|
I think that's all I have. |
| * | ||
| * MDN | ||
| */ | ||
| var permission: String = js.native |
There was a problem hiding this comment.
Which makes me realize this should not be there.
| @@ -18,7 +18,7 @@ object NodeAppendChild { | |||
| @JSExport | |||
| def main(div: html.Div) = { | |||
| val child = dom.document | |||
| .createElement("div") | |||
| .createElement("div") | |||
There was a problem hiding this comment.
Please revert all the changes to Example.scala. It should not be touched by this PR.
|
That's all. |
add onclick event to Notification Options
|
doh! .. thought I reverted example back to the original state. What am I missing to get it back there? |
|
Superseded by #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.