Remove ServiceWorkerContainer.onerror

[unarist]

It looks like not documented in the spec nor implemented in browsers.
see w3c/ServiceWorker#912

The current spec has messageerror event instead, but I'm omitting it because it is not described at MDN nor implemented Chrome for now. Tell me if I should include it in this PR.

[armanbilge]

@unarist apologies that we are just getting to this, thank you for your contribution!! Have there been any relevant updates to the spec since your PR?

[unarist]

Have there been any relevant updates to the spec since your PR?

The spec seems to not changed about this.

MDN docs had been updated to deprecate ServiceWorkerContainer.onerror.

For ServiceWorkerContainer.onmessageerror, MDN still not documented this property but Chrome had been implemented this (before my PR??).

[armanbilge]

@unarist thanks for getting back on this! onerror seems long gone, let's proceed with your PR for 1.2.0.

[japgolly]

Ok @unarist & @armanbilge , in order to preserve backwards-binary-compatibility, I've restored the field but marked it as deprecated. We'll remove all the deprecated stuff on the 2.x branch (or not)

[armanbilge]

Wait, why is this binary incompatible?

[armanbilge]

This is a facade so it falls under the exceptions: #461 (comment)

[japgolly]

ARGH! Thanks @armanbilge , I forgot this case is an SJS bincomat exception. D'oh. I'll revert...

[armanbilge]

I wonder if we could use your scalafix to generate list of MiMa exceptions, so we can just run MiMa. One day!

[japgolly]

Actually yeah, that's a really good idea. I should be able to implement that reasonably quickly. I'll see if I can smash it out today...

[armanbilge]

@japgolly You rock!! Your scalafix wizardry has already opened my eyes 🤩 Plus I think this could be super-helpful for a future auto-generation scheme.

[japgolly]

Boom. Merged. Thanks for the PR (and your incredible patience) @unarist , and thanks for you attentive reviewing. :)

[armanbilge]

That was our last PR! How do you feel about cutting a release @japgolly? The remaining issues look like infrastructure/internal stuff mostly: https://github.com/scala-js/scala-js-dom/milestone/1