Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio API changes #797

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Audio API changes #797

wants to merge 42 commits into from

Conversation

yilinwei
Copy link
Contributor

@yilinwei yilinwei commented Jul 22, 2023

This is in progress at the moment, since I have an active project which is binding to most of these methods.

I'm opening it, mainly so that there's some visibility on the changes which I'm in the progress of making.

I haven't copy-pasted the docs nor run some of the release reports yet and won't until I finish the changes.

EDIT:

This is ready for review/merging.

@armanbilge
Copy link
Member

@yilinwei is this PR ready-for-review? otherwise do you mind if we mark as draft so you can un-draft it when it's ready :)

@armanbilge armanbilge marked this pull request as draft September 26, 2023 15:55
@yilinwei
Copy link
Contributor Author

yilinwei commented Sep 27, 2023 via email

@yilinwei yilinwei marked this pull request as ready for review December 29, 2023 16:53
@yilinwei yilinwei changed the title WIP: Audio API changes Audio API changes Dec 29, 2023
@armanbilge armanbilge self-requested a review December 29, 2023 17:01
@zetashift
Copy link
Contributor

Thank you for this! I'll find some time to review this ASAP, and we're hoping to cut a release (with this PR) sometime in January.

@zainab-ali
Copy link

Thanks! I've addressed all the feedback - let me know if we've missed anything.

@zetashift
Copy link
Contributor

Thank you both a lot for this! I'll wait till @armanbilge reviewed this as well before merging, because reviewing is quite a manual task and I might have missed something.

@zainab-ali
Copy link

@armanbilge would you be able to take a look when you have the chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants