-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio API changes #797
base: main
Are you sure you want to change the base?
Audio API changes #797
Conversation
@yilinwei is this PR ready-for-review? otherwise do you mind if we mark as draft so you can un-draft it when it's ready :) |
It's not ready, I'm still slowly playing around with the APIs to make sure
they're correct.
Please mark it as a draft; I didn't realise that was a feature at all!
…On Tue, 26 Sep 2023, 16:55 Arman Bilge, ***@***.***> wrote:
@yilinwei <https://github.com/yilinwei> is this PR ready-for-review?
otherwise do you mind if we mark as draft so you can un-draft it when it's
ready :)
—
Reply to this email directly, view it on GitHub
<#797 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEE6CADCHUR3XPZBCRIU53X4L3HNANCNFSM6AAAAAA2UB4UV4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
dom/src/main/scala/org/scalajs/dom/AudioWorkletGlobalScope.scala
Outdated
Show resolved
Hide resolved
Thank you for this! I'll find some time to review this ASAP, and we're hoping to cut a release (with this PR) sometime in January. |
dom/src/main/scala/org/scalajs/dom/AudioBufferSourceNodeOptions.scala
Outdated
Show resolved
Hide resolved
dom/src/main/scala/org/scalajs/dom/AudioNodeChannelInterpretation.scala
Outdated
Show resolved
Hide resolved
dom/src/main/scala/org/scalajs/dom/AudioNodeChannelCountMode.scala
Outdated
Show resolved
Hide resolved
dom/src/main/scala/org/scalajs/dom/AudioWorkletGlobalScope.scala
Outdated
Show resolved
Hide resolved
Thanks! I've addressed all the feedback - let me know if we've missed anything. |
Thank you both a lot for this! I'll wait till @armanbilge reviewed this as well before merging, because reviewing is quite a manual task and I might have missed something. |
@armanbilge would you be able to take a look when you have the chance? |
This is in progress at the moment, since I have an active project which is binding to most of these methods.
I'm opening it, mainly so that there's some visibility on the changes which I'm in the progress of making.
I haven't copy-pasted the docs nor run some of the release reports yet and won't until I finish the changes.
EDIT:
This is ready for review/merging.