Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Run tests with valgrind #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Run tests with valgrind #104

wants to merge 3 commits into from

Conversation

kornilova203
Copy link
Member

Closes #84
I am not satisfied with the implementation because memory checks are executed with regular tests and it take a lot of time.
I did not find a way to filter tests by substring (there is testOnly but does not allow to exclude tests)
I am not sure whether I should move them to separate test class, it feels like they fit to BindgenSpec.

@jonas
Copy link
Member

jonas commented Jul 6, 2018

We could run the checks in a separate build in the matrix, which only runs the tests that exercise scala-native-bindgen. When the bindings get added we can also use those to test with valgrind.

@kornilova203
Copy link
Member Author

I updated scripts for travis such that it runs memory checks only in build with llvm 5.0.
Not sure if I did it right because I added sbt command alias that includes all tests except memory tests:

addCommandAlias(
  "verifyWithoutMemoryChecks",
  "; ^test:compile ; " +
    "^testOnly -- -z \"should exist\" -z \"correct bindings\" ; " +
    "^scripted ; " +
    "docs/makeSite")

So when new tests are added verifyWithoutMemoryChecks should be updated.

@jonas
Copy link
Member

jonas commented Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants