Improve tooling and sbt-plugin error handling #144
Conversation
|
|
||
| result match { | ||
| case Right(binding) => | ||
| binding.writeToFile(outputFile) |
There was a problem hiding this comment.
My suggestion is to eventually remove error emitting code from these tests so we can add assert(binding.errors.isEmpty) here.
There was a problem hiding this comment.
But we still want to check what bindings are generated if a header file cannot be perfectly converted to Scala code.
For example we check that literal define is skipped if its value does not fit into Scala type.
Even if we check in BindgenReportingSpec that warning is printed for this case it does not guarantee that the code is not outputted.
There was a problem hiding this comment.
Assuming these are edge cases it could still make sense to have them in the reporting spec.
| @@ -52,7 +53,7 @@ sealed trait Bindgen { | |||
| /** | |||
| * Run binding generator | |||
| */ | |||
| def generate(): Bindings | |||
| def generate(): Either[Seq[String], Bindings] | |||
There was a problem hiding this comment.
👍
Also maybe update the comment:
/**
* Run binding generator
* @return errors if exit code was not 0, otherwise return bindings
*/| @@ -33,51 +33,57 @@ class BindgenReportingSpec extends FunSpec { | |||
| .excludePrefix("__") | |||
| .generate() | |||
|
|
|||
| result match { | |||
| case Right(binding) => assert(binding.errors == errors) | |||
| case Left(bindingErrors) => assert(bindingErrors == errors) | |||
There was a problem hiding this comment.
I think we should fail test if case Left
Supersedes #142 (except for the
configchange).