Skip to content

Don't push Docker images #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Don't push Docker images #180

merged 2 commits into from
Aug 28, 2018

Conversation

jonas
Copy link
Member

@jonas jonas commented Aug 28, 2018

Since we now provide binaries for each release there's no longer a need
for providing Docker images.

Since we now provide binaries for each release there's no longer a need
for providing Docker images.
@jonas
Copy link
Member Author

jonas commented Aug 28, 2018

The build for master now passes, so pushing to Docker works again. https://travis-ci.org/scala-native/scala-native-bindgen/builds/421549751

We might still want to remove this deployment though.

on:
tags: true
- provider: script
script: scripts/docker-deploy.sh "$TRAVIS_COMMIT" latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove docker-deploy.sh?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point I will update the PR

@jonas jonas merged commit c1eca2f into master Aug 28, 2018
@jonas jonas deleted the remove-docker-deploy branch August 28, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants