Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes/changelog/version diff for dependencies in private GitHub repos #1468

Closed
MPV opened this issue Jun 4, 2020 · 5 comments · Fixed by #2920
Closed

Add release notes/changelog/version diff for dependencies in private GitHub repos #1468

MPV opened this issue Jun 4, 2020 · 5 comments · Fixed by #2920
Labels
enhancement New feature or request

Comments

@MPV
Copy link

MPV commented Jun 4, 2020

These nice features don't work for dependencies whose git repos are private (thus need auth):

  • Release Notes
  • Changelog
  • Version Diff

This is probably because the http client used for those doesn't seem to use the github token:

https://github.com/fthomas/scala-steward/blob/master/modules/core/src/main/scala/org/scalasteward/core/util/HttpExistenceClient.scala

@MPV MPV changed the title Auth for PR to add links for private GitHub repos in dependencies Add release notes/changelog/version for dependencies in private GitHub repos Jun 4, 2020
@MPV MPV changed the title Add release notes/changelog/version for dependencies in private GitHub repos Add release notes/changelog/version diff for dependencies in private GitHub repos Jun 4, 2020
@exoego exoego added the enhancement New feature or request label Feb 9, 2022
@laughedelic
Copy link

laughedelic commented Jan 10, 2023

The linked file doesn't exist anymore. Could any of the maintainers point to the potential places that would need changing to make it work with private repos?

@fthomas
Copy link
Member

fthomas commented Jan 10, 2023

HttpExistenceClient has been renamed to UrlChecker. I think the Client used by UrlChecker needs do authenticated calls for anything that goes to VCSCfg#apiHost. I once tried this in this old branch (https://github.com/scala-steward-org/scala-steward/compare/topic/VCSClient) but then ran out of steam.

@fthomas
Copy link
Member

fthomas commented Jan 14, 2023

There is now a PR at #2920 that fixes this if someone wants to give it a try.

@laughedelic
Copy link

Great news! Thanks!

Can I try this version with the scala-steward-action?

@fthomas
Copy link
Member

fthomas commented Jan 19, 2023

Yes, just set the scala-steward-version option of the action to 0.20.0-61-1f0282a6-SNAPSHOT for example. Available snapshot versions are here: https://oss.sonatype.org/content/repositories/snapshots/org/scala-steward/scala-steward-core_2.13/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants