Run Mill 0.12 with --ticker=false
#3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fthomas
force-pushed
the
fix/mill-plugin/64
branch
from
75d4946 to
f0943c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3511 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 171 171
Lines 3530 3531 +1
Branches 332 332
=======================================
+ Hits 3165 3166 +1
Misses 365 365 ☔ View full report in Codecov by Sentry. |
mzuehlke
approved these changes
Dec 30, 2024
|
I found that the scala-steward action still failed. Should I wait for a new steward version to be released? |
|
You can use the latest Scala Steward snapshot with the Action: #1468 (comment) |
|
@fthomas Good, it works well now. Thank you a lot. |
|
Thanks for confirming that it works now. I just released Scala Steward 0.32.1 which includes this fix, so you can remove the |
fthomas
added a commit
that referenced
this pull request
Jan 12, 2025
Running Mill 0.11 with `--ticker=false` (which has been added in #3511) produces the following error: ``` Parsing exception Position 1:9, found "=false" ``` The `--ticker <bool>` option has been added to Mill in 0.12.0 if I'm reading [this commit](com-lihaoyi/mill@0c44ffa) correctly. We therefore need to use `--disable-ticker` with Mill 0.11 and `--ticker false` with Mill >= 0.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3478
Closes: scala-steward-org/mill-plugin#64